-
Notifications
You must be signed in to change notification settings - Fork 183
migration_with_external_tpm: fix label issue #6735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis change modifies the cleanup_test function in the migration vTPM test file. The conditional that controlled execution of Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The auto cases under migration_with_external_tpm are failing because correct label is not getting attached to it due to image_mode condition,
changing if condition to not image_mode sets the /usr/bin/swtpm_setup correct label, which fixes the failed cases.
bf1959d to
560261e
Compare
yanqzhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for fixing this logic issue.
chunfuwen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@yanqzhan Please review the changes.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.